Skip to content

HTTPCLIENT-2379: Add H2SharingConnPool test for multiple removal of same PoolEntry#665

Merged
arturobernalg merged 1 commit into
apache:masterfrom
yhzdys:master
Jul 3, 2025
Merged

HTTPCLIENT-2379: Add H2SharingConnPool test for multiple removal of same PoolEntry#665
arturobernalg merged 1 commit into
apache:masterfrom
yhzdys:master

Conversation

@yhzdys

@yhzdys yhzdys commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

Issue Link: HTTPCLIENT-2379

See Also: #663

@yhzdys yhzdys changed the title HTTPCLIENT-2379: Add H2SharingConnPool test for multiple removal of s… HTTPCLIENT-2379: Add H2SharingConnPool test for multiple removal of same PoolEntry Jul 2, 2025
@yhzdys yhzdys closed this Jul 2, 2025
@yhzdys yhzdys reopened this Jul 2, 2025
@yhzdys yhzdys mentioned this pull request Jul 2, 2025
Closed
@yhzdys

yhzdys commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

@arturobernalg
The PR I submitted is meant to reproduce the issue, so it fails the integration tests.
Should I take any further steps?

@arturobernalg

arturobernalg commented Jul 2, 2025

Copy link
Copy Markdown
Member

@arturobernalg The PR I submitted is meant to reproduce the issue, so it fails the integration tests. Should I take any further steps?

@yhzdys Please adjust the test so it merely reproduces the problem without breaking the build— by asserting the expected IllegalStateException

@yhzdys

yhzdys commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

@arturobernalg The PR I submitted is meant to reproduce the issue, so it fails the integration tests. Should I take any further steps?

@yhzdys Please adjust the test so it merely reproduces the problem without breaking the build— by asserting the expected IllegalStateException

@arturobernalg Done. Test asserts the expected IllegalStateException.

arturobernalg
arturobernalg approved these changes Jul 2, 2025
View reviewed changes

@arturobernalg arturobernalg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arturobernalg arturobernalg merged commit 5c6c135 into apache:master Jul 3, 2025
10 checks passed
@ok2c

ok2c commented Jul 3, 2025

Copy link
Copy Markdown
Member

@arturobernalg Could you please cherry-pick this change-set to 5.5.x as well?

arturobernalg pushed a commit that referenced this pull request Jul 3, 2025
@yhzdys @arturobernalg
HTTPCLIENT-2379: Add H2SharingConnPool test for multiple removal of s…
2c159a5 
…ame PoolEntry (#665)

(cherry picked from commit 5c6c135)
@arturobernalg

arturobernalg commented Jul 3, 2025

Copy link
Copy Markdown
Member

@arturobernalg Could you please cherry-pick this change-set to 5.5.x as well?

@ok2c done

@ok2c

ok2c commented Jul 6, 2025

Copy link
Copy Markdown
Member

@arturobernalg Could you please cherry-pick this change-set to 5.5.x as well?

@ok2c done

@arturobernalg I do not see the commit in 5.5.x. Could you please double-check and re-commit if needed?

@arturobernalg

arturobernalg commented Jul 6, 2025

Copy link
Copy Markdown
Member

@arturobernalg Could you please cherry-pick this change-set to 5.5.x as well?

@ok2c done

@arturobernalg I do not see the commit in 5.5.x. Could you please double-check and re-commit if needed?

@ok2c my bad. Should be fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ok2c ok2c ok2c approved these changes

@arturobernalg arturobernalg arturobernalg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yhzdys @arturobernalg @ok2c